Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export types for facade api #4126

Merged
merged 1 commit into from
Nov 22, 2024
Merged

feat: export types for facade api #4126

merged 1 commit into from
Nov 22, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Nov 22, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 22, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  19 passed
flaky  1 flaky

Details

stats  20 tests across 9 suites
duration  5 minutes, 46 seconds
commit  952d6e8
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.76%. Comparing base (19808d0) to head (952d6e8).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4126   +/-   ##
=======================================
  Coverage   33.76%   33.76%           
=======================================
  Files        2457     2457           
  Lines      127783   127783           
  Branches    28614    28614           
=======================================
  Hits        43141    43141           
  Misses      84642    84642           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jikkai jikkai merged commit 0d07c86 into dev Nov 22, 2024
9 checks passed
@jikkai jikkai deleted the types/facade branch November 22, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants