Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(facade): export syncExecuteCommand #4102

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

hexf00
Copy link
Member

@hexf00 hexf00 commented Nov 19, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@hexf00 hexf00 requested a review from wzhudev as a code owner November 19, 2024 06:37
Copy link

github-actions bot commented Nov 19, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@hexf00 hexf00 changed the title docs: update docs feat(facade): export syncExecuteCommand Nov 19, 2024
Copy link

Playwright test results

passed  18 passed
flaky  1 flaky

Details

stats  19 tests across 9 suites
duration  5 minutes, 9 seconds
commit  4dfdd43
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.07%. Comparing base (e194a1e) to head (4dfdd43).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
packages/core/src/facade/f-univer.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4102      +/-   ##
==========================================
- Coverage   33.07%   33.07%   -0.01%     
==========================================
  Files        2438     2438              
  Lines      126753   126755       +2     
  Branches    28357    28357              
==========================================
  Hits        41921    41921              
- Misses      84832    84834       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@hexf00 hexf00 merged commit d882624 into dev Nov 19, 2024
10 checks passed
@hexf00 hexf00 deleted the feat/export-sync-execute-command branch November 19, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants