Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheets-ui): add hover facade api #4092

Merged
merged 3 commits into from
Nov 19, 2024
Merged

feat(sheets-ui): add hover facade api #4092

merged 3 commits into from
Nov 19, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Nov 18, 2024

  • fWorkbook.onCellHover
  • fWorkbook.onCellClick
  • fRange.highlight

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 18, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 18, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 39 seconds
commit  88bc0ec
info  For more information, see full report

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 33.04%. Comparing base (9b1a5be) to head (88bc0ec).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
packages/sheets-ui/src/facade/f-workbook.ts 0.00% 8 Missing ⚠️
packages/sheets-ui/src/facade/f-range.ts 0.00% 7 Missing ⚠️
...es/sheets-ui/src/services/hover-manager.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4092      +/-   ##
==========================================
- Coverage   33.04%   33.04%   -0.01%     
==========================================
  Files        2437     2437              
  Lines      126822   126837      +15     
  Branches    28395    28396       +1     
==========================================
  Hits        41912    41912              
- Misses      84910    84925      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@wzhudev wzhudev merged commit a23f2fb into dev Nov 19, 2024
9 checks passed
@wzhudev wzhudev deleted the feat/hover-facade branch November 19, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants