Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move range selection not showing when dragging a selection #4082

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 15, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 15, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 39 seconds
commit  7c66d57
info  For more information, see full report

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 32.99%. Comparing base (629db60) to head (7c66d57).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...rc/services/selection/selection-shape-extension.ts 0.00% 11 Missing ⚠️
...src/services/selection/selection-render.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4082      +/-   ##
==========================================
- Coverage   32.99%   32.99%   -0.01%     
==========================================
  Files        2437     2437              
  Lines      126787   126798      +11     
  Branches    28380    28384       +4     
==========================================
  Hits        41834    41834              
- Misses      84953    84964      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku merged commit 9310099 into dev Nov 16, 2024
9 checks passed
@lumixraku lumixraku deleted the fix/selection-highlight-hotfix branch November 16, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants