Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete apply #4062

Merged
merged 3 commits into from
Nov 14, 2024
Merged

fix: delete apply #4062

merged 3 commits into from
Nov 14, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Nov 14, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 14, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 14, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 41 seconds
commit  71155b1
info  For more information, see full report

@Jocs Jocs marked this pull request as ready for review November 14, 2024 10:05
@Jocs Jocs requested a review from wzhudev as a code owner November 14, 2024 10:05
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 65.21739% with 8 lines in your changes missing coverage. Please review.

Project coverage is 32.95%. Comparing base (6423ff8) to head (71155b1).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
...e/src/docs/data-model/text-x/apply-utils/common.ts 16.66% 5 Missing ⚠️
packages/core/src/shared/doc-tool.ts 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4062      +/-   ##
==========================================
+ Coverage   32.93%   32.95%   +0.01%     
==========================================
  Files        2497     2497              
  Lines      126904   126919      +15     
  Branches    28413    28419       +6     
==========================================
+ Hits        41792    41821      +29     
+ Misses      85112    85098      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs merged commit 820653c into dev Nov 14, 2024
13 checks passed
@Jocs Jocs deleted the fix/delete-apply branch November 14, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants