-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sheet): cell related facade api #4032
Conversation
View Deployment
|
Playwright test resultsDetails
Flaky testschromium › memory/memory.spec.ts › memory |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4032 +/- ##
==========================================
+ Coverage 33.07% 33.32% +0.25%
==========================================
Files 2438 2440 +2
Lines 126762 126792 +30
Branches 28357 28364 +7
==========================================
+ Hits 41921 42250 +329
+ Misses 84841 84542 -299 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some usability details need to be addressed.
I am marking this PR as verified because it only changes API. |
73164fa
to
d50d2e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3beec64
to
771754e
Compare
de65ea5
to
5efbcff
Compare
What's updated?
Facade API
onCellRender
refreshCanvas
onBeforeCellEdit
onAfterCellEdit
Docs
Write API documentation after the new documentation system is built
How to test?
Testing with Uniscript
onCellRender
andrefreshCanvas
Case 1, fixed position rendering, adding rows will not affect the rendering position
Case 2, rendering by markup, the mark position will change with the row and column, and the rendering position will also change accordingly
onBeforeCellEdit
onAfterCellEdit
Pull Request Checklist