Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(render-engine): paragraph horizontal align #4010

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Nov 8, 2024

close https://github.com/dream-num/univer-pro/issues/2930

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs marked this pull request as ready for review November 8, 2024 08:32
@Jocs Jocs requested a review from lumixraku as a code owner November 8, 2024 08:32
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 8, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 39 seconds
commit  4993a8e
info  For more information, see full report

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 32.84%. Comparing base (d793188) to head (4993a8e).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...nts/docs/layout/block/paragraph/line-adjustment.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4010      +/-   ##
==========================================
- Coverage   32.84%   32.84%   -0.01%     
==========================================
  Files        2501     2501              
  Lines      126541   126543       +2     
  Branches    28338    28338              
==========================================
  Hits        41566    41566              
- Misses      84975    84977       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo
Copy link

oumomomo commented Nov 8, 2024

选中段落设置右对齐后长按几秒空格,再次选中内容时选中态超出页面
2024_11_8 17_58_20 video.webm
image

@univer-bot
Copy link

univer-bot bot commented Nov 8, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

After selecting the paragraph and setting the right alignment, press and hold the space for a few seconds. When the content is selected again, the selected state exceeds the page.
2024_11_8 17_58_20 video.webm
image

@oumomomo oumomomo added qa:rejected and removed qa:untested This PR is ready to be tested labels Nov 8, 2024
@Jocs
Copy link
Contributor Author

Jocs commented Nov 8, 2024

选中段落设置右对齐后长按几秒空格,再次选中内容时选中态超出页面 2024_11_8 17_58_20 video.webm image

这个是符合预期的,word google 也类似

@univer-bot
Copy link

univer-bot bot commented Nov 8, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

After selecting the paragraph and setting right alignment, press and hold the space for a few seconds. When the content is selected again, the selected state exceeds the page [2024_11_8 17_58_20 video.webm](https://github.com/user-attachments/assets/b8e32a8b-4f2f-414f-976e -a8dee4586deb)! [Image] (https://private- user-images.githubusercontent.com/167171356/38432083789-03a6-da-da-505df8bdd9f3.p3.p3.p3.p3.p3.p3.p3.p3.p3.p3.p3.p3.p3.p3.p3.P ng? JWT = EYJHBGCIOJIUZI1NISINR5CCI6IKPXVCJ9.EYJPC3MIOIJNAXRODW mtletuilcjlehaioje3mzewnja3odCSIM5IZII6MTCZMTA2MDQ4NYWICGF0ACI6 WNWRMOGJKZDLMMMY5WBMC_WC1BXOTQWXNB3JPDGHTPUFXUZQTSE1BQY1TSEEYN Tymwc1bbxotq3jlzgvdGlhbd1BVKNPRFLMU1M1BRSZRAQSUYRJIWMJQ XMTA4JTJGDXMMWFZWFZDC0XJTJGCZMLMKZHD3M0X3JLCXVLC3QMWC1BBXOTRGF0ZT0MDI0MTEWOFQXMDDDDDAJLGTQW16CGLGLGTQW16LVNPZPZPZPZ 25hdhvyzt1mowMytewzdjlotixNDaxzmu0yjq5mgrlnMy5otbiy2Jindhkzgm 1MZU2NTDJNMIYKZDKXZGE5ywywjlz25LzehlywrlCNM9AG 9ZDCJ9.2Criwalmyunsb5ykoxjotyn7ggRN3RT2KYYYKD0B39OQ)

This is in line with expectations, word google is also similar

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 8, 2024
@univer-bot univer-bot bot removed the qa:rejected label Nov 8, 2024
@Jocs Jocs merged commit 045eef3 into dev Nov 8, 2024
13 checks passed
@Jocs Jocs deleted the fix/paragraph-align branch November 8, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants