Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uni): uni toolbar init #3973

Merged
merged 6 commits into from
Nov 13, 2024
Merged

fix(uni): uni toolbar init #3973

merged 6 commits into from
Nov 13, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Nov 6, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 6, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 6, 2024

Playwright test results

passed  18 passed
flaky  1 flaky

Details

stats  19 tests across 9 suites
duration  5 minutes, 7 seconds
commit  3d53844
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 32.93%. Comparing base (6db18f3) to head (3d53844).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
...imental/uniui/src/views/uni-toolbar/UniToolbar.tsx 0.00% 21 Missing ⚠️
...al/uniui/src/views/uni-toolbar/UniFloatToolbar.tsx 0.00% 9 Missing ⚠️
...mental/uni-formula-ui/src/uni-formula-ui.plugin.ts 0.00% 2 Missing ⚠️
packages-experimental/uniui/src/plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3973   +/-   ##
=======================================
  Coverage   32.93%   32.93%           
=======================================
  Files        2496     2497    +1     
  Lines      126832   126904   +72     
  Branches    28401    28413   +12     
=======================================
+ Hits        41766    41792   +26     
- Misses      85066    85112   +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir force-pushed the feat/uni-home-project branch 4 times, most recently from 82d4e8a to f5fe562 Compare November 12, 2024 07:34
@Dushusir Dushusir force-pushed the feat/uni-home-project branch from 13b78be to 4ca3ffa Compare November 13, 2024 07:48
@Dushusir Dushusir marked this pull request as ready for review November 13, 2024 12:45
@Dushusir Dushusir requested review from jikkai, wzhudev, yuhongz and hexf00 and removed request for jikkai and wzhudev November 13, 2024 12:45
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hexf00 hexf00 merged commit 8cf801a into dev Nov 13, 2024
9 checks passed
@hexf00 hexf00 deleted the feat/uni-home-project branch November 13, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants