Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(formula): dependency v4 #3969

Merged
merged 67 commits into from
Nov 8, 2024
Merged

perf(formula): dependency v4 #3969

merged 67 commits into from
Nov 8, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Nov 6, 2024

What‘s updated?

  • Formula calculation performance optimization
  • Facade API setInitialFormulaComputing. Forced calculations are time-consuming, and the default valueless calculation can improve performance.
 univerAPI.getSheetsFormula().setInitialFormulaComputing(0) // Force calculation of all formulas
 univerAPI.getSheetsFormula().setInitialFormulaComputing(1) // Partial calculation, only cells with formulas but no v values are calculated
 univerAPI.getSheetsFormula().setInitialFormulaComputing(2) // All formulas are not calculated

How to test?

  1. Facade API setInitialFormulaComputing.
2024-11-06.120018.mp4

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

DR-Univer and others added 30 commits October 28, 2024 02:40
@DR-Univer DR-Univer requested a review from Jocs as a code owner November 6, 2024 03:41
Copy link

github-actions bot commented Nov 6, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 6, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 39 seconds
commit  85140b1
info  For more information, see full report

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 36.08074% with 760 lines in your changes missing coverage. Please review.

Project coverage is 32.81%. Comparing base (6721d8d) to head (85140b1).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...formula/src/services/dependency-manager.service.ts 31.84% 137 Missing ⚠️
...ormula/src/engine/dependency/formula-dependency.ts 52.17% 110 Missing ⚠️
.../src/controllers/trigger-calculation.controller.ts 0.00% 75 Missing ⚠️
...e-formula/src/engine/dependency/dependency-tree.ts 56.87% 69 Missing ⚠️
...services/conditional-formatting-formula.service.ts 3.70% 52 Missing ⚠️
packages/core/src/shared/r-tree.ts 0.00% 39 Missing ⚠️
...es/engine-formula/src/models/formula-data.model.ts 13.63% 38 Missing ⚠️
...ula/src/services/register-other-formula.service.ts 0.00% 23 Missing ⚠️
...lidation/src/services/dv-custom-formula.service.ts 0.00% 20 Missing ⚠️
...ting/src/services/calculate-unit/highlight-cell.ts 12.50% 14 Missing ⚠️
... and 37 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3969      +/-   ##
==========================================
+ Coverage   32.71%   32.81%   +0.10%     
==========================================
  Files        2498     2497       -1     
  Lines      126644   126667      +23     
  Branches    28356    28358       +2     
==========================================
+ Hits        41426    41567     +141     
+ Misses      85218    85100     -118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer added the qa:untested This PR is ready to be tested label Nov 6, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 6, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 6, 2024
@Dushusir Dushusir requested a review from wzhudev November 6, 2024 11:06
@Dushusir Dushusir marked this pull request as draft November 6, 2024 12:02
@Dushusir Dushusir marked this pull request as ready for review November 8, 2024 03:54
@Dushusir Dushusir requested a review from hexf00 as a code owner November 8, 2024 03:54
@Dushusir Dushusir requested a review from wzhudev November 8, 2024 04:11
@Dushusir Dushusir merged commit 196d0d8 into dev Nov 8, 2024
9 checks passed
@Dushusir Dushusir deleted the perf-dependency-v4 branch November 8, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants