Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty strings should be treated as having no value when merge #3963

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Nov 5, 2024

close https://github.com/dream-num/univer-pro/issues/3046

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@ybzky ybzky requested review from jikkai and wzhudev as code owners November 5, 2024 11:32
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 5, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 40 seconds
commit  81acccf
info  For more information, see full report

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.71%. Comparing base (39d0d46) to head (81acccf).
Report is 12 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3963      +/-   ##
==========================================
+ Coverage   32.46%   32.71%   +0.25%     
==========================================
  Files        2427     2438      +11     
  Lines      126046   126501     +455     
  Branches    28196    28333     +137     
==========================================
+ Hits        40915    41380     +465     
+ Misses      85131    85121      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 5, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 5, 2024
@wzhudev wzhudev merged commit 238eef1 into dev Nov 6, 2024
9 checks passed
@wzhudev wzhudev deleted the fix-merge-empty-value branch November 6, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants