Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): table context menu disable status #3921

Merged
merged 3 commits into from
Nov 2, 2024
Merged

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Nov 1, 2024

close https://github.com/dream-num/univer-pro/issues/2951

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs marked this pull request as ready for review November 1, 2024 05:01
@Jocs Jocs requested a review from jikkai as a code owner November 1, 2024 05:01
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 1, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 38 seconds
commit  955dfd3
info  For more information, see full report

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 32.34%. Comparing base (71eca33) to head (955dfd3).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
...kages/docs-ui/src/controllers/menu/context-menu.ts 0.00% 22 Missing ⚠️
packages/docs-ui/src/controllers/menu/menu.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3921      +/-   ##
==========================================
+ Coverage   32.30%   32.34%   +0.03%     
==========================================
  Files        2457     2457              
  Lines      125911   125885      -26     
  Branches    28114    28107       -7     
==========================================
+ Hits        40677    40717      +40     
+ Misses      85234    85168      -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 1, 2024
@oumomomo
Copy link

oumomomo commented Nov 2, 2024

选中表格+内容,右键菜单内插入&表格删除按钮未隐藏
image

@univer-bot
Copy link

univer-bot bot commented Nov 2, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Select the table + content, and the insert and table delete buttons in the right-click menu are not hidden.
image

@Jocs Jocs added the qa:untested This PR is ready to be tested label Nov 2, 2024
@univer-bot univer-bot bot removed the qa:rejected label Nov 2, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 2, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 2, 2024
@Jocs Jocs merged commit 05339d2 into dev Nov 2, 2024
9 checks passed
@Jocs Jocs deleted the fix/table-context-menu branch November 2, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants