Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change mode set cursor #3915

Merged
merged 1 commit into from
Nov 1, 2024
Merged

fix: change mode set cursor #3915

merged 1 commit into from
Nov 1, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Oct 31, 2024

close https://github.com/dream-num/univer-pro/issues/2965

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs marked this pull request as ready for review October 31, 2024 13:05
@Jocs Jocs requested a review from jikkai as a code owner October 31, 2024 13:05
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Oct 31, 2024
Copy link

github-actions bot commented Oct 31, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 38 seconds
commit  38d3192
info  For more information, see full report

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 32.31%. Comparing base (5db9233) to head (38d3192).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/docs-ui/src/basics/selection.ts 0.00% 9 Missing ⚠️
...src/commands/commands/doc-header-footer.command.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3915      +/-   ##
==========================================
- Coverage   32.31%   32.31%   -0.01%     
==========================================
  Files        2456     2457       +1     
  Lines      125870   125878       +8     
  Branches    28107    28108       +1     
==========================================
  Hits        40672    40672              
- Misses      85198    85206       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 1, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 1, 2024
@Jocs Jocs merged commit be77b78 into dev Nov 1, 2024
9 checks passed
@Jocs Jocs deleted the fix/change-mode-set-cursor branch November 1, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants