Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect losses_q #61

Open
zilin129 opened this issue Mar 26, 2021 · 3 comments
Open

Incorrect losses_q #61

zilin129 opened this issue Mar 26, 2021 · 3 comments

Comments

@zilin129
Copy link

losses_q is supposed to be all losses on query set across all tasks. But it is defined as below. That's all the losses on query set for all the update_step for task i, not all the task.
losses_q = [0 for _ in range(self.update_step + 1)]
Is this an error?

@NookLook2014
Copy link

losses_q is supposed to be all losses on query set across all tasks. But it is defined as below. That's all the losses on query set for all the update_step for task i, not all the task.
losses_q = [0 for _ in range(self.update_step + 1)]
Is this an error?

so, you are suggesting losses_q = [0 for _ in range(self.update_step*task_num + 1)] to accumulate all query loss?

@tim-hash
Copy link

No it is not an error. They create a list the length of the number of inner update step then accumulate the loss on each task at that particular step i.e losses_q[3] will be the sum of loss of each task for the update step 4. He then proceed to take only the final value of the list and to average on that is done with loss_q = losses_q[-1] / task_num on line 134 .

@woundenfish
Copy link

No it is not an error. +=. [-1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants