Minor corrections to Translator use #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documented the `position` configuration item, needed if you want to see the prompt and text blocks recognised
Trying to tidy up the numbered bullet list.
If at first you don't succeed...
...try, try, try then find a different way to work around the issue.
…m there now, according to the official module documentation :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following an issue on the MagicMirror itself (see issue MagicMirrorOrg/MagicMirror#388) regarding translations, it appears that your use of
Translator.translations[this.name]...wasn't consistent with the way MagicMirror handles langauges and fallbacks.This PR shouldn't change any functionality, but uses the
Translator.translatefunction to ensure that the code searches both the given translation and the fallbackTranslation to retrieve the necessary details.Apologies for the fussy semicolon/formatting changes - force of habit :(