Fix CreatePartitionsRequest_v0 #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
StephenSorriaux
deleted the
fix/create-topics-request-is-an-array-of-array
branch
|
Facing the same issue and found this comment. Got confused when first reading the document on (CreatePartitions API). Is it possible to update the document on this part? |
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Aug 1, 2018
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
While using your library to develop an Ansible module, I noticed that the current CreatePartitionsRequest_v0 is wrong since 'assignment' is an Array of Array of Int32 (see https://github.com/apache/kafka/blob/a553764c8b1611cafd318022d0fc4a34c861f6ba/clients/src/main/java/org/apache/kafka/clients/admin/NewPartitions.java#L37)
Tested in my project, everything is fine now.
Regards,
Stephen