-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: azure user info claims and JWT decode #2121
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2121 +/- ##
==========================================
+ Coverage 78.49% 78.64% +0.15%
==========================================
Files 72 72
Lines 8685 8687 +2
==========================================
+ Hits 6817 6832 +15
+ Misses 1868 1855 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for fixing this!
No problem, thank you for your contribution once more, this looks way better now. |
This PR brings all the necessary changes to upgrade to FAB 4.3.9 from 4.3.6. It incorporates those changes: * dpgaspar/Flask-AppBuilder#2112 * dpgaspar/Flask-AppBuilder#2121 It also removes the limitation of the WTForms after compatibility has been implemented: * dpgaspar/Flask-AppBuilder#2138
This PR brings all the necessary changes to upgrade to FAB 4.3.9 from 4.3.6. It incorporates those changes: * dpgaspar/Flask-AppBuilder#2112 * dpgaspar/Flask-AppBuilder#2121 It also removes the limitation of the WTForms after compatibility has been implemented: * dpgaspar/Flask-AppBuilder#2138
This PR brings all the necessary changes to upgrade to FAB 4.3.9 from 4.3.6. It incorporates those changes: * dpgaspar/Flask-AppBuilder#2112 * dpgaspar/Flask-AppBuilder#2121 It also removes the limitation of the WTForms after compatibility has been implemented: * dpgaspar/Flask-AppBuilder#2138 GitOrigin-RevId: 4198146f49b72d051d82fbd821c7105cf2f4a8bd
This PR brings all the necessary changes to upgrade to FAB 4.3.9 from 4.3.6. It incorporates those changes: * dpgaspar/Flask-AppBuilder#2112 * dpgaspar/Flask-AppBuilder#2121 It also removes the limitation of the WTForms after compatibility has been implemented: * dpgaspar/Flask-AppBuilder#2138 GitOrigin-RevId: 4198146f49b72d051d82fbd821c7105cf2f4a8bd
This PR brings all the necessary changes to upgrade to FAB 4.3.9 from 4.3.6. It incorporates those changes: * dpgaspar/Flask-AppBuilder#2112 * dpgaspar/Flask-AppBuilder#2121 It also removes the limitation of the WTForms after compatibility has been implemented: * dpgaspar/Flask-AppBuilder#2138 GitOrigin-RevId: 4198146f49b72d051d82fbd821c7105cf2f4a8bd
Description
Follow up PR for: #2112
Changes:
id_token
from Azure is not always signed, won't verify signature unless set on the config for the provider withverify_signature
cc: @wolfdn
ADDITIONAL INFORMATION