fix: Make sure user input is not treated as safe in the oauth view #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1978 +/- ##
=======================================
Coverage 78.13% 78.13%
=======================================
Files 71 71
Lines 8612 8612
=======================================
Hits 6729 6729
Misses 1883 1883
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@dpgaspar Can you review this change? It solves a upstream Issue in apache airflow which allows XSS via the next paramter |
dpgaspar
approved these changes
Feb 1, 2023
9 tasks
AVMusorin
added a commit
to AVMusorin/Flask-AppBuilder
that referenced
this pull request
Jun 5, 2023
Since next parameter shouldn't be used with `safe` Jinja filter (see dpgaspar#1978), to avoid double escaping we can use Jinja's `urlencode`. Also, it might be clearer to work with this parameter in the related libraries, no need to double unquote the url.
AVMusorin
added a commit
to AVMusorin/Flask-AppBuilder
that referenced
this pull request
Jun 5, 2023
Since next parameter shouldn't be used with `safe` Jinja filter (see dpgaspar#1978), to avoid double escaping we can use Jinja's `urlencode`. Also, it might be clearer to work with this parameter in the related libraries, no need to double unquote the url.
6 tasks
dpgaspar
added a commit
that referenced
this pull request
Jun 20, 2023
Since next parameter shouldn't be used with `safe` Jinja filter (see #1978), to avoid double escaping we can use Jinja's `urlencode`. Also, it might be clearer to work with this parameter in the related libraries, no need to double unquote the url. Co-authored-by: Daniel Vaz Gaspar <[email protected]>
|
Was an advisory ever published for this issue? I don't think I see it at https://github.com/dpgaspar/Flask-AppBuilder/security |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a security issue issue with the next parameter in the OAUTH Login field.
The user can edit the next field from within the URL, this can cause reflected XSS.
for example /login/?next="-alert(document.location)-" will alert the document location.
ADDITIONAL INFORMATION