Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support user-configurable Firebase SDK component versions on iOS #246

Open
dpa99c opened this issue Dec 3, 2019 · 5 comments
Open
Labels
Blocked Development is blocked by a 3rd party dependency feature request New feature request Firebase SDK Relates to the Firebase SDK library which this plugin wraps ios relates to iOS platform

Comments

@dpa99c
Copy link
Owner

dpa99c commented Dec 3, 2019

Currently this plugin supports user-configurable version overrides for the Android Firebase SDK components pulled in via Gradle by using Cordova plugin variables set at plugin install time.

However, currently Cordova doesn't support the use of plugin variables in plugin podspecs for iOS so the same can't be done for the iOS Firebase SDK components out-of-the-box.

But it may be possible to implement an emulation of this using plugin hook scripts to extract the version values from plugin variables and apply them directly to the iOS platform project to allow user-configurable overrides to also work for iOS.

@dpa99c
Copy link
Owner Author

dpa99c commented Dec 3, 2019

BTW this would make it easier to resolve issues such as #232 by manually setting the SDK component versions.

@dpa99c dpa99c added feature request New feature request Firebase SDK Relates to the Firebase SDK library which this plugin wraps ios relates to iOS platform TODO Something needs doing labels Dec 3, 2019
@dpa99c
Copy link
Owner Author

dpa99c commented Feb 19, 2020

Support for plugin variables in podspecs for iOS has been added to cordova-ios in this PR.

At this time, the change is on the master branch but has not been released to npm in the latest release version [email protected].

When this change is released in the next cordova-ios release, this plugin can make use of it to define default versions for iOS Firebase SDK components in the podspec which can overridden by plugin variables, in the same way it does for Gradle artefact versions on Android.

@dpa99c dpa99c added Blocked Development is blocked by a 3rd party dependency and removed TODO Something needs doing labels Feb 19, 2020
@stale
Copy link

stale bot commented May 12, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 12, 2021
@stale stale bot closed this as completed May 19, 2021
@dpa99c
Copy link
Owner Author

dpa99c commented Jul 23, 2021

Reopening as stalebot incorrectly closed it

@dpa99c dpa99c reopened this Jul 23, 2021
@dpa99c dpa99c removed the wontfix label Jul 23, 2021
@TiBz0u
Copy link

TiBz0u commented Sep 23, 2022

Hi @dpa99c, thanks for the new feature in the 14.2.0
(iOS) feat: add support for IOS_FIREBASE_SDK_VERSION plugin variable to override the Firebase iOS SDK versions specified in plugin.xml

I'm wondering if we can align Android & iOS with the preference tag following the PR GH-754 present in the version 6.x of cordova-ios.

Maybe there was a specific reason of the JS hook

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Development is blocked by a 3rd party dependency feature request New feature request Firebase SDK Relates to the Firebase SDK library which this plugin wraps ios relates to iOS platform
Projects
None yet
Development

No branches or pull requests

2 participants