Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android build error after update the plugin to 7.0.0 #218

Closed
wenj5335 opened this issue Nov 11, 2019 · 6 comments
Closed

Android build error after update the plugin to 7.0.0 #218

wenj5335 opened this issue Nov 11, 2019 · 6 comments
Labels
android Relates to Android platform bug Something isn't working properly build issue An issue related to build process

Comments

@wenj5335
Copy link

Bug report

Current behavior:
After upgrade from v6.1.0 to v7.0.0, when I run command cordova run android it show the error

Expected behavior:
The build process should be success without issue.

Steps to reproduce:

Screenshots
image

Environment information

  • Cordova CLI version
    • cordova -v9.0.0
  • Cordova platform version
    • cordova platform android v8.1.0
  • Plugins & versions installed in project (including this plugin)
    • cordova plugin cordova-plugin-firebasex v7.0.0

Related code:
image



Other information:

@dpa99c
Copy link
Owner

dpa99c commented Nov 11, 2019

Please post the contents of your AndroidManifest.xml so the problematic <meta-data> element can be identified.
Also try removing/re-adding the Android platform to see if this resolves the issue.

@dpa99c dpa99c added android Relates to Android platform awaiting response If no response, issue will be closed build issue An issue related to build process investigate Issue requires investigation more info needed Further information is requested. If not provided, issue will be closed labels Nov 11, 2019
@Starofall
Copy link

I had the same issue. Might have been an undefined @colors/accent variable.
I got this issue fixed by reinstalling with ANDROID_ICON_ACCENT.

cordova plugin add cordova-plugin-firebasex --variable ANDROID_ICON_ACCENT=#FF123456

  "cordova": {
    "plugins": {
   ...
      "cordova-plugin-firebasex": {
        "ANDROID_ICON_ACCENT": "#FF123456", // ADD THIS

@dpa99c
Copy link
Owner

dpa99c commented Nov 11, 2019

I'm guessing this is related to commit bda54cb and that it happens if you don't specify a custom accent colour during plugin installation.
This change was an attempt to fix #132 but it probably now needs a custom fallback in the hook script to read the default value from plugin.xml if there's not a custom value in config.xml or package.json.

@dpa99c dpa99c added bug Something isn't working properly TODO Something needs doing and removed awaiting response If no response, issue will be closed more info needed Further information is requested. If not provided, issue will be closed labels Nov 11, 2019
@wenj5335
Copy link
Author

@Starofall actually i have define the ANDROID_ICON_ACCENT in colors.xml and this is working in previous version of firebasex
image

@wenj5335
Copy link
Author

image
This is the result after cordova platform add android

@wenj5335
Copy link
Author

I had the same issue. Might have been an undefined @colors/accent variable.
I got this issue fixed by reinstalling with ANDROID_ICON_ACCENT.

cordova plugin add cordova-plugin-firebasex --variable ANDROID_ICON_ACCENT=#FF123456

  "cordova": {
    "plugins": {
   ...
      "cordova-plugin-firebasex": {
        "ANDROID_ICON_ACCENT": "#FF123456", // ADD THIS

@Starofall Thanks, your solution is working

@dpa99c dpa99c closed this as completed in 1410ea4 Nov 12, 2019
@dpa99c dpa99c added ready for release Something has been implemented and is awaiting release to npm and removed TODO Something needs doing investigate Issue requires investigation ready for release Something has been implemented and is awaiting release to npm labels Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Relates to Android platform bug Something isn't working properly build issue An issue related to build process
Projects
None yet
Development

No branches or pull requests

3 participants