Bump WRITE_EXTERNAL_STORAGE to 32 for camera #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
PR Checklist
For bug fixes / features, please check if your PR fulfills the following requirements:
What is the purpose of this PR?
requestCameraAuthorization in API 30 requests WRITE_EXTERNAL_STORAGE, however, if it has not already been granted, it fails because maxSdkPermissionMap was set to 29. This prevents new authorizations from being given for camera use in API 30.
I increased it to 32 to allow all API < 33 to work.
Does this PR introduce a breaking change?
What testing has been done on the changes in the PR?
I have tested it on Android level 9, 11, 12, and 13.
What testing has been done on existing functionality?
I used it to take a picture and otherwise exercise its functionality and nothing else seems to have changed.
Other information