Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getBackgroundRefreshStatus missing return statement? #389

Closed
scyclops opened this issue Feb 11, 2020 · 1 comment
Closed

getBackgroundRefreshStatus missing return statement? #389

scyclops opened this issue Feb 11, 2020 · 1 comment

Comments

@scyclops
Copy link

It looks like there might need to be a return statement after line 84 in getBackgroundRefreshStatus in Diagnostic.m in order to prevent the error callback from being triggered along with another error or success callback immediately after.

cordova-diagnostic-plugin/src/ios/Diagnostic.m

Line 84 in a55fb69

[self handlePluginException:exception :command];

@dpa99c
Copy link
Owner

dpa99c commented Feb 11, 2020

Thanks, you are right.

@dpa99c dpa99c closed this as completed in 3b1c868 Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scyclops @dpa99c