Posible memory leak in version 2.3.10-api-22

[hugomenesesp]

When signing APK with the new version of Cordova (6.4.0), there's a error because a posible memory leak:

:lintVitalRelease<ROUTE_TO_PROJECT>/platforms/android/src/cordova/plugins/Diagnostic.java:167: Error: The WIFI_SERVICE must be looked up on the Application context or memory will leak on devices < Android N. Try changing this.cordova.getActivity() to this.cordova.getActivity().getApplicationContext() [WifiManagerLeak]
                modeName = "unknown";
^
/Users/hugo/Documents/GIT/appmimovistar/platforms/android/src/cordova/plugins/Diagnostic.java:218: Error: The WIFI_SERVICE must be looked up on the Application context or memory will leak on devices < Android N. Try changing this.cordova.getActivity() to this.cordova.getActivity().getApplicationContext() [WifiManagerLeak]
        Intent settingsIntent = new Intent(Settings.ACTION_WIFI_SETTINGS);
                     ^

   Explanation for issues of type "WifiManagerLeak":
   On versions prior to Android N (24), initializing the WifiManager via
   Context#getSystemService can cause a memory leak if the context is not the
   application context. Change context.getSystemService(...) to
   context.getApplicationContext().getSystemService(...).

2 errors, 0 warnings

That new version of Cordova uses Gradle 4.1, older versions use 2.14.1

[hugomenesesp]

Related Stackoverflow thread: https://stackoverflow.com/a/47319534/1583507

[dpa99c]

Your are explicitly using the v2.3.10-api-22 tag of the api-22 branch which is deprecated and (as documented) is no longer maintained.

The api-22 branch was created at the time that API 23 (Android 6.0 Marshmallow) had just been released and many developers had not yet updated their code to use Android run-time permissions. Android apps should by now be updated to handle run-time permissions on Android and therefore this branch is no longer necessary.

Instead use the npm releases from the master branch which has been updated to fix the stricter checks under Gradle 4 and so will build fine with [email protected], which targets API 26.

[hugomenesesp]

The problem is that my app needs to be compatible from API 19, will it work?

[dpa99c]

cordova-android@6:

Minimum Supported Android Version is Jellybean (API 16/ Android 4.1)

[dpa99c]

i.e. both this plugin and [email protected] are backwardly-compatible to API 16

[hugomenesesp]

The fix should be the same as #251
Solution seems to be ok