requestLocationAuthorization successcallback triggers too early

[HuaHub]

cordova.plugins.diagnostic.requestLocationAuthorization(successCallback, errorCallback, mode);

The successcallback triggers too early, resulting in "status" in always "not determined", instead of the user's choice.

[dpa99c]

Please provide some more information:

• Cordova platform version (cordova-android/cordova-ios) e.g. [email protected]
• Platform (Android or iOS)
• Platform type (device or emulator)
• Platform version e.g. iOS 10.3
• Platform details (device type or emulator details) e.g. iPhone 6

[HuaHub]

Cordova 6.5.0
IOS
Device: iPhone 6
iOS: 10.2.1

[dpa99c]

I'm unable to reproduce your issue running the example project in the iOS 10.2 Simulator - see this screencast.

Please try building and running the example project and confirm if you get the same result.

[HuaHub]

Thanks for the screencast.

IOS Platform 4.3.1 btw.
I upgraded to iOS10.3, but the successcallback still runs instantly.

Sorry, I don't have the opportunity to run the example project this week.

[dpa99c]

Notify with details if still an issue and I will reopen

[0x62]

This is still an issue (encountered myself), however I've found a way to resolve it.

If you use requestLocationAuthorization before calling getLocationAuthorizationStatus, it sees the change of authorization state from undefined to not_determined, and triggers the callback before the user acts on the dialog. If you use getLocationAuthorizationStatus, then request authorization it functions as expected.

This is my (very sloppy) patch for a demo I was working on: https://gist.github.com/0x62/56d6b70aec2d832cf35e4ed01892a590

[dpa99c]

Will look into it

[0x62]

I've only debugged on iOS, so not sure whether the issue is the same for Android.

ionic: 3.0.0
cordova: 7.0.0
iOS: 10.3.1

[dpa99c]

@0x62 Thanks for your explanation of the issue - I was able to reproduce it and have fixed it in the above commit, published to npm as v3.6.3.