Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor enterprise script #270

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Refactor enterprise script #270

merged 1 commit into from
Jun 1, 2023

Conversation

dozoisch
Copy link
Owner

@dozoisch dozoisch commented May 30, 2023 •
edited
Loading

@dozoisch
Refactor enterprise script
35fdca9 
- fix failing test
- refactor to reduce duplication of access & simplify checks
@dozoisch dozoisch requested a review from hartzis May 30, 2023 00:09
@dozoisch dozoisch self-assigned this May 30, 2023
@dozoisch
Copy link
Owner Author

dozoisch commented May 30, 2023 •
edited
Loading

@nike1v could you take a look as well !

@dozoisch dozoisch mentioned this pull request May 30, 2023
Merged
@dozoisch dozoisch merged commit c723a18 into master Jun 1, 2023
@dozoisch
Copy link
Owner Author

dozoisch commented Jun 1, 2023

Thanks @hartzis :) I'll try to cut a release tonight

@dozoisch dozoisch deleted the enterprise-refactor branch June 1, 2023 14:30
@nike1v
Copy link

nike1v commented Jun 5, 2023

@nike1v could you take a look as well !

TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hartzis hartzis hartzis approved these changes

Assignees

@dozoisch dozoisch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dozoisch @nike1v @hartzis