Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH-agent protocol #197

Open
soraxas opened this issue Jul 24, 2024 · 2 comments
Open

SSH-agent protocol #197

soraxas opened this issue Jul 24, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@soraxas
Copy link
Contributor

soraxas commented Jul 24, 2024

Just an idea:

Do you think the current rbw agent can be extended to perform SSH agent protocol by directly retrieving ssh keys from entries within rbw (e.g. supplying ssh-keys with bitwarden items that begins with name prefix like SSH_KEY_xxxx)

This crate seems relevant to this idea:
https://docs.rs/ssh-agent-lib/latest/ssh_agent_lib/

The goal would be removing the needs to store secret key directly on machines

@doy
Copy link
Owner

doy commented Jul 28, 2024

this would probably be possible, but i don't know that it is entirely necessary? i solve this issue by using a wrapper script for ssh which sets the SSH_ASKPASS environment variable to a script that runs rbw get (you can see the details at https://github.com/doy/conf/blob/main/rbw/.bin/ssh and https://github.com/doy/conf/blob/main/rbw/.bin/ssh-askpass). i'm not necessarily against using the ssh-agent protocol here, but it seems like it might just be a lot of work for not much benefit?

@doy doy added the enhancement New feature or request label Jul 28, 2024
@Glandos
Copy link
Contributor

Glandos commented Nov 23, 2024

Even if I developped https://framagit.org/Glandos/bw-ssh/ it seems that SSH keys are becoming a reality, at least in Vaultwarden: dani-garcia/vaultwarden#5187
It's still experimental, and requires the desktop clients, but it's a good time to check if it matches rbw goals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants