[main] Update dependencies from dotnet/arcade #12873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…203.6 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.XUnitExtensions From Version 10.0.0-beta.25074.4 -> To Version 10.0.0-beta.25103.6
![dotnet-policy-service[bot]](https://avatars.githubusercontent.com/in/285228?s=60&v=4){kind=small}
…204.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.XUnitExtensions From Version 10.0.0-beta.25074.4 -> To Version 10.0.0-beta.25104.2
dotnet-maestro
bot
dismissed
dotnet-policy-service[bot]’s stale review
via
b8b4697
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12873 +/- ##
===================================================
- Coverage 76.13460% 76.09624% -0.03837%
===================================================
Files 3251 3255 +4
Lines 642520 642882 +362
Branches 47286 47315 +29
===================================================
+ Hits 489180 489209 +29
- Misses 149798 150114 +316
- Partials 3542 3559 +17
Flags with carried forward coverage won't be shown. Click here to find out more. |
Tanya-Solyanik
approved these changes
Feb 6, 2025
Tanya-Solyanik
deleted the
darc-main-432ec7cd-4bce-4719-b72c-f652d72a555d
branch
Tanya-Solyanik
added a commit
to Tanya-Solyanik/winforms
that referenced
this pull request
Feb 8, 2025
…s started to fail on th epublising stage. https://dev.azure.com/dnceng/internal/_build/results?buildId=2637287&view=results This stage reads the "BAR manifests" - a list of our nuget packages that looks like this <Package Id="Microsoft.Dotnet.WinForms.ProjectTemplates" Version="10.0.0-preview.2.25106.1" NonShipping="true" Visibility="External"/> <Package Id="Microsoft.Private.Winforms" Version="10.0.0-preview.2.25106.1" NonShipping="true" Visibility="External"/> <Package Id="System.Drawing.Common" Version="10.0.0-preview.2.25106.1" DotNetReleaseShipping="true" Visibility="External"/> <Package Id="System.Private.Windows.Core.TestUtilities" Version="10.0.0-preview.2.25106.1" NonShipping="true" Visibility="External"/> "BAR manifest" is generated on the "Pack Sign and Publish" step. Before the PR from arcade, this step was generating manifest named AssetManifest\Windows_NT-AnyCPU.xml for each architecture, overriding the previously written one inplace. Then the publish step was processeng that manifest. After the arcade PR we are generating 3 manifests, one for each architecture. Windows_Arm64.xml Windows_x64.xml Windows_x86.xml probably because of this change dotnet/arcade@232c628 We need only a single manifest and a single set of the nugets, thus we should run the publishing step only for x64. I don't know why build-PR script has the "Pack, Sign. publish" step because it does not actually run "Skipping step due to condition evaluation." I think this step can only run in AzDO (looking at publish.proj in arcade) I'm open to removing this step.
Tanya-Solyanik
added a commit
that referenced
this pull request
Feb 10, 2025
…ted to fail on th epublising stage. https://dev.azure.com/dnceng/internal/_build/results?buildId=2637287&view=results This stage reads the "BAR manifests" - a list of our nuget packages that looks like this <Package Id="Microsoft.Dotnet.WinForms.ProjectTemplates" Version="10.0.0-preview.2.25106.1" NonShipping="true" Visibility="External"/> <Package Id="Microsoft.Private.Winforms" Version="10.0.0-preview.2.25106.1" NonShipping="true" Visibility="External"/> <Package Id="System.Drawing.Common" Version="10.0.0-preview.2.25106.1" DotNetReleaseShipping="true" Visibility="External"/> <Package Id="System.Private.Windows.Core.TestUtilities" Version="10.0.0-preview.2.25106.1" NonShipping="true" Visibility="External"/> "BAR manifest" is generated on the "Pack Sign and Publish" step. Before the PR from arcade, this step was generating manifest named AssetManifest\Windows_NT-AnyCPU.xml for each architecture, overriding the previously written one inplace. Then the publish step was processeng that manifest. After the arcade PR we are generating 3 manifests, one for each architecture. Windows_Arm64.xml Windows_x64.xml Windows_x86.xml probably because of this change dotnet/arcade@232c628 We need only a single manifest and a single set of the nugets, thus we should run the publishing step only for x64. I don't know why build-PR script has the "Pack, Sign. publish" step because it does not actually run "Skipping step due to condition evaluation." I think this step can only run in AzDO (looking at publish.proj in arcade) I'm open to removing this step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
Microsoft Reviewers: Open in CodeFlow