Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code Doesn't honor "nowarn" in project.json for CS1591 disabling xmlDoc comments #542

Closed
greghroberts opened this issue Jul 8, 2016 · 3 comments
Assignees
Milestone

Comments

@greghroberts
Copy link

Environment data

dotnet --info output:
.NET Command Line Tools (1.0.0-preview2-003121)

Product Information:
Version: 1.0.0-preview2-003121
Commit SHA-1 hash: 1e9d529bc5

Runtime Environment:
OS Name: Mac OS X
OS Version: 10.11
OS Platform: Darwin
RID: osx.10.11-x64

VS Code version:
Version 1.2.1 (1.2.1)

C# Extension version:
1.2.1

Steps to reproduce

Set build options to:

"buildOptions": {
    "emitEntryPoint": true,
    "preserveCompilationContext": true,
    "warningsAsErrors": true,
    "nowarn": [
      "CS1591"
    ],
    "xmlDoc": true
  },

Expected behavior

public class and properties should not have a red squiggly.

Actual behavior

Red squiggly.
image

@anfomin
Copy link

anfomin commented Aug 23, 2016

This issue reproduces in the latest OmniSharp. Any updates?

@anfomin
Copy link

anfomin commented Sep 7, 2016

It's very inconvenient to find real warnings and errors in the list of 1207 items:
2016-09-07 10 00 52

However this warnings are in ignore list in project.json:

"buildOptions": {
    "emitEntryPoint": true,
    "preserveCompilationContext": true,
    "xmlDoc": true,
    "nowarn": [ "CS1591", "CS1573" ]
}

@craig006
Copy link
Contributor

craig006 commented Nov 8, 2016

Has anyone figured out a workaround for this? I've also bumped into it and its really difficult to spot actual errors and warnings with so much in the way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants