-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET Core attach debugger template defaults to "processname" and the flydown says use "pid" #142
Comments
Sounds reasonable. @caslan @DustinCampbell anyone have an opinion as to if we should change this for RC2? |
It'd be nice to make it work. 😄 |
It's very low risk so I'm in favor of changing especially now running apps via dotnet ... is more common |
Yes, should be ~0 risk. |
@MattGertz are you okay taking this? |
I'm OK but it will need an escrow check from Dmitry/JoC. |
Talked with Gregg offline; I didn't realize that there was a distinct part from the error message change. This won't meet an escrow bar; we can pick it up afterwards. |
Sounds good. Anyway, there'll be interim releases available that we can point customers to afterward. |
Fixed with #197 |
Was this issue fixed? |
@kerryjiiang: It is fixed in the dev branch in our RTM milestone. |
When you try to debug attach a .NET Core application the default launch.json has "processname", but if you use "dotnet" it says it has found multiple and you need to use "pid". But in reality you need to use "processId". I recommend that we change the default template to replace "processName" with "processId" and update the fly down text to use "processId" instead of "pid".
The text was updated successfully, but these errors were encountered: