Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Core attach debugger template defaults to "processname" and the flydown says use "pid" #142

Closed
jeffschwMSFT opened this issue Apr 5, 2016 · 11 comments
Assignees
Labels
Milestone

Comments

@jeffschwMSFT
Copy link
Member

screen shot 2016-04-05 at 11 09 50 am

When you try to debug attach a .NET Core application the default launch.json has "processname", but if you use "dotnet" it says it has found multiple and you need to use "pid". But in reality you need to use "processId". I recommend that we change the default template to replace "processName" with "processId" and update the fly down text to use "processId" instead of "pid".

@gregg-miskelly
Copy link
Contributor

Sounds reasonable. @caslan @DustinCampbell anyone have an opinion as to if we should change this for RC2?

@DustinCampbell
Copy link
Member

It'd be nice to make it work. 😄

@caslan
Copy link
Contributor

caslan commented Apr 5, 2016

It's very low risk so I'm in favor of changing especially now running apps via dotnet ... is more common

@gregg-miskelly
Copy link
Contributor

Yes, should be ~0 risk.

@DustinCampbell DustinCampbell added this to the 1.0.0-rc2 milestone Apr 5, 2016
@gregg-miskelly
Copy link
Contributor

@MattGertz are you okay taking this?

@MattGertz
Copy link

I'm OK but it will need an escrow check from Dmitry/JoC.

@MattGertz
Copy link

Talked with Gregg offline; I didn't realize that there was a distinct part from the error message change. This won't meet an escrow bar; we can pick it up afterwards.

@gregg-miskelly gregg-miskelly removed this from the 1.0.0-rc2 milestone Apr 5, 2016
@DustinCampbell
Copy link
Member

Sounds good. Anyway, there'll be interim releases available that we can point customers to afterward.

@DustinCampbell DustinCampbell added this to the 1.0.0-rtm milestone Apr 6, 2016
@gregg-miskelly gregg-miskelly removed their assignment Apr 13, 2016
@caslan caslan self-assigned this Apr 15, 2016
@caslan
Copy link
Contributor

caslan commented Apr 18, 2016

Fixed with #197

@caslan caslan closed this as completed Apr 18, 2016
@kerryjiang
Copy link

Was this issue fixed?
I tried the v1.0.5-rc2, it still stays there.

@DustinCampbell
Copy link
Member

@kerryjiiang: It is fixed in the dev branch in our RTM milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants