Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception experience in VS Code is somwhat confusing #1007

Closed
gregg-miskelly opened this issue Dec 1, 2016 · 8 comments · Fixed by #1648
Closed

Exception experience in VS Code is somwhat confusing #1007

gregg-miskelly opened this issue Dec 1, 2016 · 8 comments · Fixed by #1648
Labels
Milestone

Comments

@gregg-miskelly
Copy link
Contributor

gregg-miskelly commented Dec 1, 2016

Environment data

VS Code version: 1.8.0-insider (Commit be33bcdb2beb2d01c76ec8f830a70feaaa6721f5)

Steps to reproduce

Run the following program under the debugger

        public static void Main(string[] args)
        {
            throw new Exception("Example Exception Message");
        }

Expected behavior

VS Code should somewhat prominently show me the Exception type, if this is an unhandled exception, and the exception message. While in this trivial example these things are obvious from looking at the code, if they exception comes from library code this is often not the case.

Actual behavior

  • The exception message can only be found by finding $exception in the locals window, which can be confusing to find if one is in a big function
  • The exception type and unhandled/handled status can be found by hovering over the 'PAUSED ON EXCEPTION' text, which is nice, but not all that discoverable

vscode-exception

Equivalent scenario with VS:
vs-exception

@gregg-miskelly
Copy link
Contributor Author

@weinand is providing a basic dialog that comes up to display the text property of the exception something that VS Code might consider adding? Or should we just try and solve this on our side by dumping more information to the console?

@DustinCampbell
Copy link
Member

@weinand: Ping?

@gregg-miskelly
Copy link
Contributor Author

@DustinCampbell Andre and Isidor are planning to look at this in January. microsoft/vscode#16860 tracks that.

@DustinCampbell
Copy link
Member

Awesome! Thanks for the update. Sounds great!

@gregg-miskelly gregg-miskelly added this to the 1.9 milestone Mar 8, 2017
@gregg-miskelly
Copy link
Contributor Author

Here is what things look like in VS Code 1.11. Remaining work is to improve our message.

exception-vscode-1 11

@weinand
Copy link

weinand commented Mar 8, 2017

@gregg-miskelly this feature is not finished yet. Please see microsoft/vscode#22078

@gregg-miskelly
Copy link
Contributor Author

@weinand ahh. Thanks!

@gregg-miskelly gregg-miskelly modified the milestones: 1.10, 1.9 Apr 12, 2017
@gregg-miskelly
Copy link
Contributor Author

This will be improved in 1.9, but there are still some changes I would like to see on the C# extension (ex: func-eval'ing the Message property) that I don't think will make 1.9, so moving out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants