-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relative git submodules are not indexed #576
Comments
What warning is reported? This scenario is covered by test |
|
Can you share the structure of all the repositories involved? That is the content of their |
Check this repository: https://github.com/NN---/sourcelinkmain
|
I have the same issue. Given
I get multiple cases of
Using MSBuild binlog, the first reference to this nonexistent path (E:\Sources\Bar.git) I see is:
So this task seems to have no problem finding the source roots and the commit hashes, but computing the RepositoryUrl for submodules goes wrong. (At first glance, it seems to be correctly appending Bar.git, just to the wrong path (the parent of the local source dir instead of the parent of the repository url.) |
Relevant file I omitted: .gitmodules:
|
Looks like GitRepository gets and reports Note: in my tree at least, .git/modules/xyzzy/config contains a remote name for the branch listed in .gitmodules, and that remote has a full URL, so I am not sure why the code does not follow that path (which would be close to how the main dir is handled anyway). |
Given git submodule with relative path:
.gitmodules
SourceLink produces a warning and doesn't index files.
It doesn't produce a warning when a full URL is specified.
The text was updated successfully, but these errors were encountered: