Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dotnet/templating version branding flow #742

Open
dagood opened this issue Aug 29, 2018 · 0 comments
Open

Fix dotnet/templating version branding flow #742

dagood opened this issue Aug 29, 2018 · 0 comments
Labels
area-product-experience Improvements in the end-user's product experience

Comments

@dagood
Copy link
Member

dagood commented Aug 29, 2018

For example, auto-update to this 2.2 manifest should make templating produce something like 1.0.2-beta4-20180819-1962051. Ideally, identical.

Auto-update looks for a OfficialBuildId element to update (in this case to 20180820-01), but templating uses:

<BuildNumber>301</BuildNumber>
<PackageDateTime>20170727</PackageDateTime>
<PackageBuildQuality>beta2</PackageBuildQuality>

I think it'd be pretty easy to make a <OfficialBuildId>20180820-01</OfficialBuildId> and use a property function to chop it down to 20180820 for PackageDateTime. There isn't a clear way to update the BuildNumber property though.

Maybe we can rig up an updater to take the actual end result package version from the manifest and split it up into these properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-product-experience Improvements in the end-user's product experience
Projects
Status: Backlog
Development

No branches or pull requests

3 participants