-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ForceDryRunSigning=true #4678
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
1 similar comment
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
T-Shirt Size: XS/S Depends on how we decide to handle non-official builds using repo official build IDs. Will also involve part of #4062 which requires ensuring that MicroBuild plugin is installed and functional. |
Closing with #4062 |
This is not being closed with #4062. #4793 must be resolved first. See https://github.com/dotnet/sdk/pull/45517/files#diff-dc549eeb99aa73960e74c9d4c160a3c76e3e414398bb348c1d5365aac0369ad5R427. |
Ahh I see, the PR moves the properties around. |
I added ForceDryRunSigning to arcade to enable use of dry run signing even when the repo thinks that its in official build modes. In those cases, it would normally only allow real signing. This needs to be removed, but requires the following:
We could also take a piecemeal approach and remove use of the switch over time, starting with official builds where real signing is functional. Once all those are done,. then we still need to avoid setting the official build id in non-official builds to complete the removal
The text was updated successfully, but these errors were encountered: