Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ForceDryRunSigning=true #4678

Open
Tracked by #3708
mmitche opened this issue Oct 16, 2024 · 6 comments
Open
Tracked by #3708

Remove ForceDryRunSigning=true #4678

mmitche opened this issue Oct 16, 2024 · 6 comments

Comments

@mmitche
Copy link
Member

mmitche commented Oct 16, 2024

I added ForceDryRunSigning to arcade to enable use of dry run signing even when the repo thinks that its in official build modes. In those cases, it would normally only allow real signing. This needs to be removed, but requires the following:

  • Non-official builds should not use the repo official build IDs (should be -ci or dev or whatever)
  • Real signing needs to be functional across all OSes.

We could also take a piecemeal approach and remove use of the switch over time, starting with official builds where real signing is functional. Once all those are done,. then we still need to avoid setting the official build id in non-official builds to complete the removal

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

1 similar comment
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ellahathaway
Copy link
Member

T-Shirt Size: XS/S

Depends on how we decide to handle non-official builds using repo official build IDs.

Will also involve part of #4062 which requires ensuring that MicroBuild plugin is installed and functional.

@mmitche
Copy link
Member Author

mmitche commented Jan 6, 2025

Closing with #4062

@ellahathaway
Copy link
Member

@mmitche
Copy link
Member Author

mmitche commented Jan 6, 2025

Ahh I see, the PR moves the properties around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready
Development

No branches or pull requests

3 participants