Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate failures in WorkloadTests when using net10.0 workload manifests #45516

Open
akoeplinger opened this issue Dec 17, 2024 · 3 comments
Assignees
Labels
Area-Workloads untriaged Request triage from a team member
Milestone

Comments

@akoeplinger
Copy link
Member

When bringing in the new workload manifests and bumping to net10.0 from #45500 we see failures in these workloads tests, these need to be investigated.

  • WorkloadTests.It_should_get_suggested_workload_by_GetRequiredWorkloads_target
  • WorkloadTests.Given_multi_target_It_should_get_suggested_workload_by_GetRequiredWorkloads_target
@marcpopMSFT
Copy link
Member

I think the test failures were because our restore logic heuristic is not always right. Can you review that logic and see if there is something obvious that should be fixed? #45500 (comment)

Basically, we try to report the fewest number of workloads to install but sometimes end up recommending wasi-experimental which should probably never be in that least for a android/ios app so there's something off.

@dsplaisted
Copy link
Member

The test was only failing on Linux, right? Are the maui workloads at all available for Linux? If they're not, then I can imagine the logic falling back to the a workload like wasi-experimental.

Maybe the test should be disabled just for Linux.

@akoeplinger
Copy link
Member Author

akoeplinger commented Dec 20, 2024

It was failing on macOS for me as well.

The full MAUI isn't available on Linux but the android workload is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Workloads untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

4 participants