Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 🟣 to step names #45494

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

MiYanni
Copy link
Member

@MiYanni MiYanni commented Dec 17, 2024

Summary

Added a purple circle to every stage, job, and step defined within the context of this repo (excluding Arcade and source-build templates). This allows you to easily identify what this repo defines when looking through a build log. With all the 1ES tasks, it hurts my brain looking through the build logs, trying to understand what we actually run. 😵‍💫

The reason I used a purple circle is because when you look up dotnet images, you see something similar to this:
image

…e context of this repo (excluding Arcade templates).
@MiYanni MiYanni requested a review from a team December 17, 2024 01:01
@MiYanni MiYanni requested review from a team as code owners December 17, 2024 01:01
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Dec 17, 2024
@mmitche
Copy link
Member

mmitche commented Dec 17, 2024

I would suggest only adding this to steps. Because most of the jobs and stages are not supplied by 1ES, I think it's adding noise to the GitHub PR view UX.

@MiYanni
Copy link
Member Author

MiYanni commented Dec 17, 2024

@mmitche Yeah. When I created the PR, I forgot that GitHub functions on a formatted string of the display names of things. Meaning, it broke our required checks since you have to reference them by that string name. So, not worth it for that reason. And the extra noise on stages/jobs.

@MiYanni MiYanni changed the title Added 🟣 to stage, job, and step names Added 🟣 to ~~stage, job, and~~ step names Dec 17, 2024
@MiYanni MiYanni changed the title Added 🟣 to ~~stage, job, and~~ step names Added 🟣 to step names Dec 17, 2024
Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember you talking about this in standup and thought it was a great idea.

Does it also need to be applied to the official yml?

@MiYanni
Copy link
Member Author

MiYanni commented Dec 20, 2024

@Forgind The pipeline definition yamls .vsts-pr.yml and .vsts-ci.yml don't currently contain any steps in them. This PR changes the templates we use to do the build that have the actual steps in them. To answer your question, this change will be applied to both the PR and official pipeline runs.

@MiYanni MiYanni enabled auto-merge December 20, 2024 20:58
@MiYanni MiYanni merged commit 2cf6150 into dotnet:main Dec 20, 2024
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants