-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 🟣 to step names #45494
Added 🟣 to step names #45494
Conversation
…e context of this repo (excluding Arcade templates).
I would suggest only adding this to steps. Because most of the jobs and stages are not supplied by 1ES, I think it's adding noise to the GitHub PR view UX. |
@mmitche Yeah. When I created the PR, I forgot that GitHub functions on a formatted string of the display names of things. Meaning, it broke our required checks since you have to reference them by that string name. So, not worth it for that reason. And the extra noise on stages/jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember you talking about this in standup and thought it was a great idea.
Does it also need to be applied to the official yml?
@Forgind The pipeline definition yamls |
Summary
Added a purple circle to every
stage, job, andstep defined within the context of this repo (excluding Arcade and source-build templates). This allows you to easily identify what this repo defines when looking through a build log. With all the 1ES tasks, it hurts my brain looking through the build logs, trying to understand what we actually run. 😵💫The reason I used a purple circle is because when you look up dotnet images, you see something similar to this:
