-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create documentation on how to safely run repro projects #45341
Comments
I think we should do this sooner rather than later. Also, can we have a |
Recommendation in this order:
Next steps:
|
Is MSBuild intended to be secure against a malicious binlog? I mean if a threat actor crafts a binlog and sends it to you as a fake repro and you replay it through MSBuild. |
Is it possible to craft a malicious binlog? My impression was that the reader looks for specific pieces and turns them into the associated events, and it just fails if something looks wrong. |
I wonder if it would be possible to post an |
I don't know why this is true, but it didn't seem to work when I tried it. I ran the following:
Between the first and second command, I renamed MSBuild,binlog to temp2.csproj. As you can see, the first build failed, and the second succeeded. I'm not clear as to why CreateManifestResourceNames is connected, though, as I didn't change the actual contents at any point...so I think that still counts as not 100% sure, but it seems like no? If it failed, I would've expected something more like "couldn't find a .*proj..." or something like that. |
We should create guidance on how to safely build and run repro projects, since building or running a project implies that you trust it. This could be separate guidance, or it could be part of #45340.
If using Windows, the guidance probably involves using Windows Sandbox, and possibly how to script it to set up an environment.
The text was updated successfully, but these errors were encountered: