-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File watcher improvements #45131
File watcher improvements #45131
Conversation
Thanks for your PR, @tmat. |
c489432
to
27fc497
Compare
27fc497
to
aaa496d
Compare
7812c52
to
d96c3d2
Compare
dfa2186
to
40b13ba
Compare
39750ca
to
e469207
Compare
@phil-allen-msft ptal |
{ | ||
return []; | ||
} | ||
|
||
// Note: | ||
// It is possible that we could have received multiple changes for a file that should cancel each other (such as Delete + Add), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Add then Delete is generally "nothing happened here". I think Delete then Add is equivalent to "Update". I'm thinking in particular about how something like the Resx code generator might work to product .Designer.cs from .resx, which could be Delete then Add. Does your change reflect DeleteThenAdd => Update? Or is that a not-hittable scenario?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, delete+add translates to update. See https://github.com/dotnet/sdk/pull/45131/files#diff-703e093881ff7958e3d7a302b86e8a2c4c7b61825e6e8a379d743f93b6def1f3R17 for all cases.
Ignore changes to files in output and intermediate output directories, unless they are listed in compiler inputs in the project file (e.g. source files generated to intermediate output directory by msbuild targets).
Ignore changes directories starting with
.
.Postprocess changes to correct for misbehaving file system events and file writes using temporary intermediate files.
Add MAUI Blazor test.
Fixes #3282
Fixes #44912
Partially fixes #45183 (the content is not reloaded, but dotnet-watch does not crash).
Fixes #45011