Run all steps in a container #44969
Run all steps in a container #44969
Conversation
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Source-build isn't running all steps in containers: https://dev.azure.com/dnceng/internal/_build/results?buildId=2585278&view=results The legs don't run the "initialize containers" step, so I'm working to determine why. This doesn't happen in PR checks. |
|
/azp run dotnet-source-build-lite |
|
No pipelines are associated with this pull request. |
This is because the internal pipelines use 1ES PTs. I'm adjusting the templates so that the containers work in with these yamls. |
ellahathaway
force-pushed
the
containers
branch
from
7dc211a to
76a4881
Compare
|
New SB pipeline run. The alpine leg times out because the build never runs. It's possible that this is related to the container not being a nonglibc-based container, but SDK has a containerized job that uses the alpine 319 with node image, and that job runs just fine. |
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ellahathaway
force-pushed
the
containers
branch
from
d0da107 to
fd1b985
Compare
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -77,6 +77,59 @@ extends: | |||
| baseline: | |||
| baselineFile: $(Build.SourcesDirectory)\.config\guardian\.gdnbaselines | |||
|
|
|||
| containers: | |||
| almaLinuxContainer: | |||
| image: mcr.microsoft.com/dotnet-buildtools/prereqs:almalinux-8-source-build | |||
There was a problem hiding this comment.
These image names are being duplicated with the variables defined in variables/vmr-build.yml. We should have a single list of image names defined so that we don't have to maintain both of these files.
There was a problem hiding this comment.
@ellahathaway, have you tried importing https://github.com/dotnet/sdk/blob/main/eng/pipelines/templates/variables/vmr-build.yml in this template and referencing the variables? I remember you mentioning having troubles utilizing variables here but don't remember what you tried.
There was a problem hiding this comment.
I did try that. From what I remember, importing the variables did not work in this instance. I will try again for sanity sake, but I think the followup here is to add a comment saying that these values need to be kept up-to-date with the values in the variables template.
There was a problem hiding this comment.
Well... it worked? Not sure what I did the first time, but it's possible that I used macro syntax instead of template expression syntax. Either way, I'll open a PR to update the variables.
It doesn't work on macOS because the option only exists in GNU cp. Follow-up to #44969
Fixes dotnet/source-build#4547
SB pipeline run (internal Microsoft link)
UB pipeline run (internal Microsoft link)
I ran the SB pipeline multiple times, and I did not encounter the issue described in dotnet/source-build#3233. Given this, I feel comfortable removing the fix added in dotnet/installer#15488 in order to workaround dotnet/source-build#4796.