Find baseline workload set in 8.0.100 folder #42435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Workloads
untriaged
nagilson
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
I looked through the logic, your well-written summary of the issue (thank you), and the existing code and your change seems sound to me. It would be ideal to have sign-off from someone who is familiar with the workload set code as I am not. I think @marcpopMSFT also suggested it's too late to take this fix, unfortunately, but if we can, we should.
marcpopMSFT
added
Servicing-consider
and removed
untriaged
|
Too late for 8.0.400 but we should take for 8.0.401. Uninstall is used by <1% of customers but it's still a good amount each month worth fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This effectively contains one commit that went into main previously but never made it into 8.0.4xx despite needing it.
This was missed for multiple reasons:
Fixes #42357 and #42358
Customer Impact
The impact of the bug is that any operation involving workload garbage collection will fail. More specifically, all workload sets are always considered 'workload sets to keep,' including the baseline workload set, during garbage collection. That baseline workload set is not in the correct folder, however, which means that although we can 'discover' it when we do an initial 'find all workload sets' step, when we move to resolve it, we can't find it. This then throws an exception. This PR enables us to find it. Though a workaround, this should work for 8.0.4xx in the long term; main has both this workaround and a better long-term fix.
Regression?
This is a fix for a regression in 8.0.4xx.
Testing
I built this change, overlaid it on an SDK with the baseline workload set, verified that that workload set was discovered during garbage collection and resolved as intended, and verified that the remainder of the operation completed successfully.
Risk
The risk of this fix is low. It permits a code path that otherwise was not otherwise available.