Enable tab-completion for nuget package versions

[baronfel]

The tab completion takes into account any fragments of the version entered, as well as the existing --prerelease flag to filter the returned versions.

Demo:

• tab completion of package id based on fragment
• --version completion of full id
• --version completion using --prerelease to allow preview versions
• --version completion using version fragments to narrow versions

Cases to cover:

• slow feeds - need some kind of max timeout to prevent hangs
  • chose a 500ms max for the autocomplete requests
• feeds that require auth - filter them out? --interactive likely will not work in a completions context
  • handled this by having any feed communication exceptions just return empty completions for that feed, this isn't critical enough to need diagnostics/loggin g

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[aortiz-msft]

@martinrrm - Would you please take a look?

[baronfel]

@martinrrm if you want to take it for a spin yourself:

• clone this PR
• build with ./build.cmd or equivalent for your platform
• run the 'dogfood' script: ./eng/dogfood.ps1 or equivalent for your platform
• your dotnet is now the freshly-built one from this PR - make sure your shell has dotnet tab completion enabled and you should be good to go!

[anangaur]

This is great addition 👏🏽👏🏽👏🏽

[JonDouglas]

🚢 IT!!!!!!!

[martinrrm]

Not sure if you need an approval from me, change looks great, there is just that improvement we can do, not sure if it's going to be done in this PR. Thanks for the change!

[baronfel]

Not sure if you need an approval from me, change looks great, there is just that improvement we can do, not sure if it's going to be done in this PR. Thanks for the change!

I actually did that improvement today! So all is looking good. I'm going to ask the SDK team for code review as well then we can merge it.

[KalleOlaviNiemitalo]

Does this deserve additions to telemetry notices? I don't remember any other tab completion in dotnet contacting network servers.

[baronfel]

Does this deserve additions to telemetry notices? I don't remember any other tab completion in dotnet contacting network servers.

I don't think it requires any additional telemetry notices - while this is novel in the sense that it checks your configured sources for packages, you're already signalling consent to communicating with those registries during restore, etc. Are there specific kinds of data you're concerned about leaking to feed owners that we can help proactively prevent?

[KalleOlaviNiemitalo]

No, I'm not concerned about any specific kind of data. I just feel that, even if a user would be happy to let dotnet restore or dotnet package search query a NuGet feed, doing the same during tab completion may be unexpected as the user did not run a command yet. However, setting up this tab completion requires deliberate user action, so if the completion script installation instructions mention this feature, that should be enough.

[baronfel]

Package Id completions seem to be broken, needs more testing

[nagilson]

I believe we had mentioned there was also an issue with the version completion, and that it should be tested in scenarios without a nuget.config.

[baronfel]

We should backport this to the 9.0.1xx release branch now that it has branched off of main.

[zivkan]

Was this tested with a private Azure DevOps feed?

By default, apps using NuGet.Protocol, SourceRepository will not look for credential providers. A static method needs to be called, and then SourceRepository will search for credential providers when it makes requests on feeds that need authentication. Unfortunately, I can't remember the name of the API, so I can't quickly search the code to see if it's being called. But if testing showed that private Azure Artifacts feeds don't work, let me know and I'll look it up.

[baronfel]

It's worse than that @zivkan - the AzDo feeds don't actually support the searchautocompleteservice resource. The Registry apis will give you and AutoCompleteResource but then blow up with a protocolexception when you try to use that resource due to lack of the necessary endpoint.

I would have expected a null instance if the Source didn't actually support autocompletion.

[nagilson]

Turns out the previous 'issues' were with the nuget.config... this is pretty awesome! Thank you for having a clean code style and writing useful comments. I could not find any bugs. I am very excited to see this feature ship 🚀

[baronfel]

/backport to release/9.0.1xx

[github-actions]

Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/10412988686