-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for updatedTypes in metadata updates #40416
feat: Add support for updatedTypes in metadata updates #40416
Conversation
Thanks for your PR, @jeromelaban. |
Note, I'm not sure how to test this properly on the CI's side, considering it requires an integration from the Blazor as well. Thanks for the reviews! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @jeromelaban!
We may also need to update this struct to have an UpdatedTypes
property and update these tests to verify it.
082183a
to
ad90515
Compare
I've tested these changes locally; with a small fix, hot reload works and the I also verified that:
|
Thanks again for the contribution, @jeromelaban! |
(Just going to wait for the aspnetcore PR to pass all its checks to make extra sure that both ends are good-to-go before merging). |
Related dotnet/aspnetcore#52937, corresponding PR in blazor: dotnet/aspnetcore#55347
This PR passes the updatedType parameter in order by the hot reload agent to properly invoke MetadatatUpdateHandler types.