Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dotnet fsi does not support DOTNET_CLI_UI_LANGUAGE #40302

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

KevinRansom
Copy link
Member

This fixes #40301
and fixes dotnet/fsharp#16146

This gets the SDK overridden language version and uses it to specify the fsi --preferreduilang command line argument, which is how fsi knows to do this.

--preferreduilang:<string>               Specify the preferred output language culture name (e.g. es-ES, ja-JP)

@KevinRansom KevinRansom requested a review from a team as a code owner April 19, 2024 06:30
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CLI untriaged Request triage from a team member labels Apr 19, 2024
@KevinRansom
Copy link
Member Author

Fix:
C:\kevinransom\sdk\artifacts\bin\redist\Debug\dotnet>set DOTNET_CLI_UI_LANGUAGE=en-En

C:\kevinransom\sdk\artifacts\bin\redist\Debug\dotnet>dotnet fsi

Microsoft (R) F# Interactive version 12.8.400.0 for F# 8.0
Copyright (c) Microsoft Corporation. All Rights Reserved.

For help type #help;;

#quit;;

C:\kevinransom\sdk\artifacts\bin\redist\Debug\dotnet>set DOTNET_CLI_UI_LANGUAGE=

C:\kevinransom\sdk\artifacts\bin\redist\Debug\dotnet>dotnet fsi

Microsoft (R) F# Interactive version 12.8.400.0 for F# 8.0
Copyright (c) Microsoft Corporation. All Rights Reserved.

For help type #help;;

#quit;;

C:\kevinransom\sdk\artifacts\bin\redist\Debug\dotnet>set DOTNET_CLI_UI_LANGUAGE=es-Es

C:\kevinransom\sdk\artifacts\bin\redist\Debug\dotnet>dotnet fsi

Microsoft (R) F# interactivo, versión 12.8.400.0 for F# 8.0
Copyright (C) Microsoft Corporation. Todos los derechos reservados.

Para obtener ayuda, escriba #help;;

@baronfel baronfel merged commit c36eda5 into dotnet:main Apr 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CLI untriaged Request triage from a team member
Projects
None yet
3 participants