Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when working directory is drive root #38050

Closed
richlander opened this issue Jan 16, 2024 · 6 comments
Closed

Error when working directory is drive root #38050

richlander opened this issue Jan 16, 2024 · 6 comments
Assignees
Milestone

Comments

@richlander
Copy link
Member

We have seen multiple cases where dotnet restore times out with an unrecoverable error when the user places an app at OS root. This is easy to do in containers/Dockerfile and is hard to diagnose. It's also not a useful pattern.

dotnet build and friends (restore, publish, test, ...) should fail when run at drive root. We can offer a --force command to override this case, however, that may not be necessary.

Context: NuGet/Home#13131

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-NetSDK untriaged Request triage from a team member labels Jan 16, 2024
@Forgind
Copy link
Member

Forgind commented Jan 30, 2024

Thanks for the report @richlander. From what you've seen, is this "common" (fix soon; serious customer pain) or "uncommon" (try to get around to it, but it isn't a top priority)?

@Forgind
Copy link
Member

Forgind commented Jan 30, 2024

I imagine the priority is a bit higher than it otherwise would be since containers are a growing area, but I haven't seen any of the user data myself.

@richlander
Copy link
Member Author

It is common enough. I've done this multiple times. It is very easy to do with Dockerfiles.

This isn't a rush. It would be great to get the fix into 8.0.400 (and 9.0), for example.

@Forgind
Copy link
Member

Forgind commented Jan 30, 2024

Sounds good!

@Forgind Forgind added needs team triage Requires a full team discussion and removed untriaged Request triage from a team member labels Jan 30, 2024
@Forgind Forgind added this to the 8.0.4xx milestone Jan 30, 2024
@richlander
Copy link
Member Author

If you want to try this yourself, make a Dockerfile and COPY source into an sdk container, build, but forget to set WORKDIR. That's the bad pattern.

@richlander
Copy link
Member Author

Thanks! I look forward to trying this. I should be able to work this into a container related blog post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants