Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch tool install to using PackageDownloader #22349

Closed
sfoslund opened this issue Oct 27, 2021 · 3 comments
Closed

Switch tool install to using PackageDownloader #22349

sfoslund opened this issue Oct 27, 2021 · 3 comments
Milestone

Comments

@sfoslund
Copy link
Member

At the moment, .NET tool install uses its own package installer to download the packages it needs using a temp project and classic restore. Now that we have the NugetPackageDownloader we can make this code a lot cleaner (and potentially faster?) by switching the old tool install download logic to use the NugetPackageDownloader.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Tools untriaged Request triage from a team member labels Oct 27, 2021
@sfoslund sfoslund removed the untriaged Request triage from a team member label Oct 27, 2021
@sfoslund sfoslund added this to the 6.0.2xx milestone Oct 27, 2021
@nkolev92
Copy link
Contributor

You'd need an assets file with the correct assets selected.
The downloader can't do that today.

The assets selection logic and assets file generation is tied into restore.

@sfoslund
Copy link
Member Author

You'd need an assets file with the correct assets selected.

Ah okay. Do you know why tool install needs the assets file? I'll close this since it sounds like we won't be able to make this change.

@nkolev92
Copy link
Contributor

Do you know why tool install needs the assets file?

That should be on SDK side. It should be something that's used when a tool is run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants