-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch exception when subscribing to NetworkChange #94861
Catch exception when subscribing to NetworkChange #94861
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #94794. We can simply swallow the exception and not monitor network changes. RFC allows us to. RFC: https://tools.ietf.org/html/rfc7838#section-2.2
|
...ibraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPoolManager.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
If we're gonna backport it, we should test it (including the cleanup code). Even if just manually with faking the exception for the sake of the test.
...ibraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPoolManager.cs
Outdated
Show resolved
Hide resolved
...ibraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPoolManager.cs
Outdated
Show resolved
Hide resolved
CI failures are unrelated |
/backport to release/8.0-staging |
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/6958490464 |
Fixes #94794.
We can simply swallow the exception and not monitor network changes. RFC allows us to.
RFC: https://tools.ietf.org/html/rfc7838#section-2.2