Build Mac symbols in .dSYM bundle, not single .dwarf file #94237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @hoyosjs Issue Detailsnull
|
|
Related: #92911 |
|
cc @ericstj Since you've done some work in these areas. |
This was referenced Oct 31, 2023
hoyosjs
reviewed
Nov 1, 2023
| @@ -18,7 +18,8 @@ | |||
| <LibPrefix>lib</LibPrefix> | |||
| <LibSuffix>.dylib</LibSuffix> | |||
| <StaticLibSuffix>.a</StaticLibSuffix> | |||
| <SymbolsSuffix>.dwarf</SymbolsSuffix> | |||
| <!-- <SymbolsSuffix>.dwarf</SymbolsSuffix> --> | |||
| <SymbolsSuffix>.dSYM</SymbolsSuffix> | |||
There was a problem hiding this comment.
This might quickly become a leaky abstraction. For example, we also are missing updating GetSymbolPackageFiles in https://github.com/dotnet/runtime/blob/main/src/installer/pkg/projects/Directory.Build.targets (the excludes and all that)
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.