Mark final types as exact #88163

MichalPetryka · 2023-06-28T21:25:10Z

Should let the JIT devirtualize way more stuff due to knowing the exact types.

Extracted from #87579.

ghost · 2023-06-28T21:26:51Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Should let the JIT devirtualize way more stuff due to knowing the exact types.

Extracted from #87579.

Author:	MichalPetryka
Assignees:	-
Labels:	`area-CodeGen-coreclr`
Milestone:	-

EgorBo · 2023-06-29T17:02:11Z

/azp list

azure-pipelines · 2023-06-29T17:02:16Z

CI/CD Pipelines for this repository: runtime-coreclr outerloop runtime-coreclr jitstress runtime-coreclr jitstressregs runtime-coreclr jitstress2-jitstressregs runtime-coreclr gcstress0x3-gcstress0xc runtime-coreclr gcstress-extra runtime-coreclr r2r-extra runtime-coreclr jitstress-isas-x86 runtime-coreclr jitstress-isas-arm runtime-coreclr jitstressregs-x86 runtime-coreclr libraries-jitstressregs runtime-coreclr libraries-jitstress2-jitstressregs runtime-coreclr r2r runtime-coreclr runincontext runtime-coreclr crossgen2 runtime-libraries-coreclr outerloop runtime-libraries-coreclr outerloop-windows runtime-libraries-coreclr outerloop-linux runtime-libraries-coreclr outerloop-osx runtime runtime-libraries enterprise-linux runtime-libraries stress-http runtime-libraries stress-ssl runtime-dev-innerloop runtime-coreclr crossgen2 outerloop coreclr-release-outerloop-nightly runtime-coreclr crossgen2-composite runtime-jit-experimental runtime-coreclr libraries-jitstress dotnet-linker-tests runtime-coreclr ilasm runtime-coreclr crossgen2-composite gcstress runtime-staging runtime-coreclr pgo runtime-coreclr libraries-pgo Antigen runtime-community Fuzzlyn runtime-coreclr superpmi-replay runtime-wasm runtime-coreclr superpmi-diffs runtime-coreclr superpmi-asmdiffs-checked-release runtime-extra-platforms jit-cfg runtime-wasm-perf runtime-llvm runtime-coreclr jitstress-random runtime-coreclr libraries-jitstress-random runtime-android-grpc-client-tests runtime-wasm-libtests runtime-wasm-non-libtests runtime-android runtime-androidemulator runtime-ioslike runtime-ioslikesimulator runtime-linuxbionic runtime-maccatalyst runtime-coreclr pgostress runtime-coreclr jitstress-isas-avx512 runtime-tools-tests runtime-libraries-mono outerloop runtime-sanitized runtime-wasm-dbgtests runtime-wasm-optional

EgorBo · 2023-06-29T17:03:33Z

/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-extra-platforms, runtime-coreclr pgostress

azure-pipelines · 2023-06-29T17:04:18Z

Azure Pipelines successfully started running 4 pipeline(s).

EgorBo · 2023-06-29T22:35:14Z

/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-extra-platforms, runtime-coreclr pgostress

azure-pipelines · 2023-06-29T22:35:41Z

Azure Pipelines successfully started running 4 pipeline(s).

MichalPetryka · 2023-06-30T22:38:47Z

@MihuBot

EgorBo · 2023-06-30T22:49:24Z

/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-extra-platforms, runtime-coreclr pgostress

azure-pipelines · 2023-06-30T22:49:48Z

Azure Pipelines successfully started running 4 pipeline(s).

src/coreclr/jit/gentree.cpp

AndyAyersMS

Seems like we ought to put the calls to getExactClasses into impIsClassExact to centralize the logic, and then just have these methods simply call impIsClassExact if they don't have exact classes.

EgorBo · 2023-07-07T17:06:16Z

Seems like we ought to put the calls to getExactClasses into impIsClassExact to centralize the logic, and then just have these methods simply call impIsClassExact if they don't have exact classes.

As far as I know that's not needed because impIsClassExact already doing the right thing on NativeAOT by checking "is effectively sealed" (meaning no subclasses)

so the getExactClasses == 1 check in this pr should be completely redundant

AndyAyersMS · 2023-07-07T17:19:45Z

Seems like we ought to put the calls to getExactClasses into impIsClassExact to centralize the logic, and then just have these methods simply call impIsClassExact if they don't have exact classes.

As far as I know that's not needed because impIsClassExact already doing the right thing on NativeAOT by checking "is effectively sealed" (meaning no subclasses)

so the getExactClasses == 1 check in this pr should be completely redundant

So (perhaps I'm finally understanding what you were saying above) the only change needed is to one call to impClassIsExact

@MichalPetryka can you please try just running with that one change?

MichalPetryka · 2023-07-10T19:57:54Z

@MihuBot -hetzner

AndyAyersMS · 2023-07-13T19:55:58Z

The x86 failure here is a bit concerning. We are crashing in the GC.

Assert failure(PID 32236 [0x00007dec], Thread: 10744 [0x29f8]): Consistency check failed: AV in clr at this callstack:
------
CORECLR! WKS::gc_heap::background_mark_simple + 0x21 (0x702b6364)
CORECLR! WKS::gc_heap::background_promote + 0x109 (0x702b6a79)
CORECLR! PinObject + 0x91 (0x702807f1)
CORECLR! ScanConsecutiveHandlesWithoutUserData + 0x44 (0x7027fab4)
CORECLR! BlockScanBlocksWithoutUserData + 0x29 (0x7027f5e9)
CORECLR! ProcessScanQNode + 0x32 (0x7027f982)

MichalPetryka · 2023-07-13T20:08:25Z

The x86 failure here is a bit concerning. We are crashing in the GC.

I don't recall that being there before, could it maybe be the rebase on top of main that caused this?

kasperk81 · 2023-07-13T20:09:37Z

    diff is a regression.
    relative diff is a regression.

262 improved, 1904 regressed

why is this acceptable?

AndyAyersMS · 2023-07-13T20:20:10Z

The x86 failure here is a bit concerning. We are crashing in the GC.

Assert failure(PID 32236 [0x00007dec], Thread: 10744 [0x29f8]): Consistency check failed: AV in clr at this callstack:
------
CORECLR! WKS::gc_heap::background_mark_simple + 0x21 (0x702b6364)
CORECLR! WKS::gc_heap::background_promote + 0x109 (0x702b6a79)
CORECLR! PinObject + 0x91 (0x702807f1)
CORECLR! ScanConsecutiveHandlesWithoutUserData + 0x44 (0x7027fab4)
CORECLR! BlockScanBlocksWithoutUserData + 0x29 (0x7027f5e9)
CORECLR! ProcessScanQNode + 0x32 (0x7027f982)

@dotnet/gc any thoughts on this? I can load up the dump but can't get SOS to work.

AndyAyersMS · 2023-07-13T20:21:00Z

    diff is a regression.
    relative diff is a regression.

262 improved, 1904 regressed

why is this acceptable?

We are expecting this change to unblock more devirtualization and inlining, so some size increases are expected.

AndyAyersMS · 2023-07-13T20:23:23Z

    diff is a regression.
    relative diff is a regression.
262 improved, 1904 regressed
why is this acceptable?
We are expecting this change to unblock more devirtualization and inlining, so some size increases are expected.

Also we expect the size increases in practice will be smaller since many of those same inlines are already happening under PGO-driven GDV. But we can't see that impact easily right now.

Once this change is in and we do new SPMI collections we can undo it and get a more accurate read on the size impact.

mangod9 · 2023-07-13T21:03:35Z

the test failure appears to be a GC hole, so might be useful to try with HeapVerify enabled to check if repros consistently.

AndyAyersMS · 2023-07-13T21:39:51Z

the test failure appears to be a GC hole, so might be useful to try with HeapVerify enabled to check if repros consistently.

Let me see if it repros in CI.

AndyAyersMS · 2023-07-13T22:52:41Z

I can't seem to get rerun to actually rerun the failing test.

@MichalPetryka please push a merge commit once #88856 is in so we can start from scratch.

EgorBo · 2023-07-16T16:11:15Z

/azp run runtime-coreclr outerloop, runtime-extra-platforms, runtime-coreclr pgostress

azure-pipelines · 2023-07-16T16:11:46Z

Azure Pipelines successfully started running 3 pipeline(s).

AndyAyersMS · 2023-07-18T14:45:23Z

Going to bounce this...

AndyAyersMS · 2023-07-18T15:02:03Z

Actually let me merge this up.

AndyAyersMS · 2023-07-18T17:47:07Z

@MichalPetryka thank you!

dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 28, 2023

ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 28, 2023

MichalPetryka requested a review from MichalStrehovsky as a code owner June 29, 2023 00:27

build-analysis bot mentioned this pull request Jun 29, 2023

windows-x86 release MSBuild_CMake is failing #88172

Closed

This was referenced Jun 30, 2023

Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637

Open

[6.0] Android test failure: Failed to install mobile app #83422

Open

MihuBot mentioned this pull request Jun 30, 2023

[MichalPetryka] Mark final types as exact MihuBot/runtime-utils#65

Open

MichalPetryka mentioned this pull request Jun 30, 2023

Improve updating classes for generics #88277

Closed

EgorBo reviewed Jul 1, 2023

View reviewed changes

src/coreclr/jit/gentree.cpp Show resolved Hide resolved

MichalPetryka mentioned this pull request Jul 5, 2023

Print variable types when dumping the output #88420

Merged

AndyAyersMS reviewed Jul 7, 2023

View reviewed changes

JulieLeeMSFT assigned EgorBo and MichalPetryka Jul 10, 2023

build-analysis bot mentioned this pull request Jul 13, 2023

Timeout in Microsoft.Gen.OptionsValidation.Unit.Test.EmitterTest #88784

Closed

EgorBo approved these changes Jul 13, 2023

View reviewed changes

MichalPetryka added 2 commits July 14, 2023 04:14

Merge branch 'dotnet:main' into patch-9

8c22577

Merge branch 'dotnet:main' into patch-9

7aa3e2d

build-analysis bot mentioned this pull request Jul 15, 2023

LibraryImportGenerator.Unit.Tests crashed in CI #87951

Closed

Merge branch 'dotnet:main' into patch-9

a7d731a

AndyAyersMS closed this Jul 18, 2023

AndyAyersMS reopened this Jul 18, 2023

Merge remote-tracking branch 'upstream/main' into patch-9

78c4b35

EgorBo merged commit be86455 into dotnet:main Jul 18, 2023

AndyAyersMS mentioned this pull request Jul 19, 2023

Optimize if range check to replace jumps to bit operation #87656

Merged

EgorBo mentioned this pull request Jul 27, 2023

[Perf] Linux/arm64: 1 Improvement on 7/20/2023 8:15:02 AM dotnet/perf-autofiling-issues#20041

Closed

ghost locked as resolved and limited conversation to collaborators Aug 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mark final types as exact #88163

Mark final types as exact #88163

MichalPetryka commented Jun 28, 2023

ghost commented Jun 28, 2023

EgorBo commented Jun 29, 2023

azure-pipelines bot commented Jun 29, 2023

EgorBo commented Jun 29, 2023

azure-pipelines bot commented Jun 29, 2023

EgorBo commented Jun 29, 2023

azure-pipelines bot commented Jun 29, 2023

MichalPetryka commented Jun 30, 2023

EgorBo commented Jun 30, 2023

azure-pipelines bot commented Jun 30, 2023

AndyAyersMS left a comment

EgorBo commented Jul 7, 2023 •

edited

Loading

AndyAyersMS commented Jul 7, 2023

MichalPetryka commented Jul 10, 2023

AndyAyersMS commented Jul 13, 2023

MichalPetryka commented Jul 13, 2023

kasperk81 commented Jul 13, 2023

AndyAyersMS commented Jul 13, 2023

AndyAyersMS commented Jul 13, 2023

AndyAyersMS commented Jul 13, 2023

mangod9 commented Jul 13, 2023

AndyAyersMS commented Jul 13, 2023

AndyAyersMS commented Jul 13, 2023

EgorBo commented Jul 16, 2023

azure-pipelines bot commented Jul 16, 2023

AndyAyersMS commented Jul 18, 2023

AndyAyersMS commented Jul 18, 2023

AndyAyersMS commented Jul 18, 2023

Mark final types as exact #88163

Mark final types as exact #88163

Conversation

MichalPetryka commented Jun 28, 2023

ghost commented Jun 28, 2023

EgorBo commented Jun 29, 2023

azure-pipelines bot commented Jun 29, 2023

EgorBo commented Jun 29, 2023

azure-pipelines bot commented Jun 29, 2023

EgorBo commented Jun 29, 2023

azure-pipelines bot commented Jun 29, 2023

MichalPetryka commented Jun 30, 2023

EgorBo commented Jun 30, 2023

azure-pipelines bot commented Jun 30, 2023

AndyAyersMS left a comment

Choose a reason for hiding this comment

EgorBo commented Jul 7, 2023 • edited Loading

AndyAyersMS commented Jul 7, 2023

MichalPetryka commented Jul 10, 2023

AndyAyersMS commented Jul 13, 2023

MichalPetryka commented Jul 13, 2023

kasperk81 commented Jul 13, 2023

AndyAyersMS commented Jul 13, 2023

AndyAyersMS commented Jul 13, 2023

AndyAyersMS commented Jul 13, 2023

mangod9 commented Jul 13, 2023

AndyAyersMS commented Jul 13, 2023

AndyAyersMS commented Jul 13, 2023

EgorBo commented Jul 16, 2023

azure-pipelines bot commented Jul 16, 2023

AndyAyersMS commented Jul 18, 2023

AndyAyersMS commented Jul 18, 2023

AndyAyersMS commented Jul 18, 2023

EgorBo commented Jul 7, 2023 •

edited

Loading