Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new SafeHandleMarshaller type to provide out-of-generator marshalling support. #85419

Merged
merged 8 commits into from
May 3, 2023
Merged

Add new SafeHandleMarshaller type to provide out-of-generator marshalling support. #85419

merged 8 commits into from
May 3, 2023

Commits on Apr 26, 2023

  1. Add new SafeHandleMarshaller type to provide out-of-generator marshal… 

    …ling support.
    @jkoritzinsky
    jkoritzinsky committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    84ab7dc View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Always call OnInvoked on marshallers no matter the direction (as a re… 

    …turn/out marshaller might still want to use it).
    @jkoritzinsky
    jkoritzinsky committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    d4fa0c2 View commit details
    Browse the repository at this point in the history

  2. Don't use OnInvoked in the unmanaged->managed marshaller. Our shape d… 

    …esign doesn't support that, so we won't use it.
    @jkoritzinsky
    jkoritzinsky committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    beae478 View commit details
    Browse the repository at this point in the history

  3. Add a test that ensures SafeHandle[]s aren't supported.

    @jkoritzinsky
    jkoritzinsky committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    0c81d9f View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Breaking change: Only support SafeHandle-derived types with public pa… 

    …rameterless constructors in the SafeHandleMarshaller.
    @jkoritzinsky
    jkoritzinsky committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    0233e2a View commit details
    Browse the repository at this point in the history

  2. Change constructor visibility in LibraryImportGenerator.Tests SafeHan… 

    …dle tests to reflect the breaking change.
    @jkoritzinsky
    jkoritzinsky committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    ea4fc5f View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. Move SafeHandle-with-private-constructor test to CompileFails.

    @jkoritzinsky
    jkoritzinsky committed May 1, 2023
    Configuration menu
    Copy the full SHA
    dfde41d View commit details
    Browse the repository at this point in the history

  2. Update compatibility doc

    @jkoritzinsky
    jkoritzinsky committed May 1, 2023
    Configuration menu
    Copy the full SHA
    c6e6c62 View commit details
    Browse the repository at this point in the history