-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support encoding TypedReference
s in signatures.
#85360
Conversation
Since we have a dedicated method for typed references, there is no reason to prohibit it.
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @dotnet/area-system-reflection-metadata Issue DetailsThis PR does two things. It adds a Fixes #80812. Tests were updated.
|
@teo-tsirpanis please add doc with triple slash comment for the, even all other similar APIs have not documented we should keep documenting the new ones at least. Other than that the PR looks good to me, thank you! |
Done @buyaa-n, I documented the entire |
...s/System.Reflection.Metadata/src/System/Reflection/Metadata/Ecma335/Encoding/BlobEncoders.cs
Outdated
Show resolved
Hide resolved
…/Metadata/Ecma335/Encoding/BlobEncoders.cs Co-authored-by: Buyaa Namnan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks you @teo-tsirpanis
This PR does two things. It adds a
SignatureTypeEncoder.TypedReference()
method and updates theSignatureTypeEncoder.PrimitiveType
method to accept values ofPrimitiveTypeCode.TypedReference
. Any of the two ways allows encoding a typed reference withSystem.Reflection.Metadata
.Fixes #80812. Tests were updated.