Re-enable gc-sections with lld for NativeAOT #84935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tnet#84493)"" This reverts the revert of commit 3ab663e. The revert of that commit was included in 887c043.
|
LGTM, thanks! Looks like dwarf dump count has increased: It is linker-dependent and yields different results for different linker optimizations. We can just adjust the values in tests. |
jkotas
approved these changes
Apr 17, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds back @am11's fix from #84493 (which I temporarily reverted in #84148), plus the patch suggested in #84493 (comment) to enable use of
lld< 13. This should allow us to continue building runtime withlld12, while supporting the gc-sections optimization when a newer lld is available.