Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace load with cheaper move instr for stack loads on Arm64 (Followup of #83458) #83886

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

SwapnilGaikwad
Copy link
Contributor

Incorporate review comments for #83458.
Encode the previous instruction's source reg to match consecutive loads from the same stack location

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 24, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 24, 2023
@ghost
Copy link

ghost commented Mar 24, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Incorporate review comments for #83458.
Encode the previous instruction's source reg to match consecutive loads from the same stack location

Author: SwapnilGaikwad
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@SwapnilGaikwad SwapnilGaikwad changed the title Followup of #83458 Replace load with cheaper move instr for stack loads on Arm64 (Followup of #83458) Mar 24, 2023
@BruceForstall
Copy link
Member

No diffs -- which as described in #83458 is both surprising but also not necessarily unexpected.

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BruceForstall BruceForstall merged commit 51fcdf7 into dotnet:main Mar 24, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants